forked from NOAA-OWP/ngen
-
Notifications
You must be signed in to change notification settings - Fork 0
DONT MERGE, JUST TESTING RUNNERS #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aaraney
wants to merge
177
commits into
master
Choose a base branch
from
ci-asan
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of pointless child class
…tor instead of pointless child class
Address issue NOAA-OWP#710. In line 79, when parsing the date column, using the dictionary, as was done before this edit, pandas attempts to parse the column at index 0, to a column 'Time'. So, if 'Time' is already a column the error in issue NOAA-OWP#710 is produced. The proposed change assumes column at index 0 is the date column, but works despite the name.
Fixed a typo of '#ifdef NGEN_C_LIB_ACTIVE' that missed the intended macro
On intel macOS, brew installs into /usr/local On apple silicon, brew installs into /opt/homebrew Use brew --prefix to resolve the right brew prefix in a platform independent manor
Updating project version in CMake build to reflect the latest "version" with an existing tag (v0.2.0).
Applying other Github Actions that run against the master branch to release branches also.
Updating Actions depending on numpy install to use pre-2.0 numpy version as is currently required for ngen builds.
Using pip constraints to ensure any downstream `input.additional_python_requirements` that may be installed also are prevented from installing a problematic version.
Cannot move to / due to read-only file system; instead, use $GITHUB_WORKSPACE in order to be able to specify absolute path to file in PIP_CONSTRAINT.
Added Apache license and copyright information for ngen repo via modification of existing LICENSE file
…e version 3.5 until pybind11 is updated
bc0ffaf to
23c49b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.